SEZ9 commented on PR #12298:
URL: https://github.com/apache/seatunnel/pull/12298#issuecomment-5825486204

   @DanielLeens, the shared-config blocker and the follow-up items are 
addressed in `5859f4e0a3cf`, rebased onto `dev` at `deb16a3c3152`.
   
   - The bound HTTP port now comes from each member's Jetty connector through 
`SeaTunnelServer`. `HttpConfig` remains unchanged. The regression fixture 
deliberately shares one HTTP config between two members and checks distinct 
ports in both `/logs` and cluster GET/POST/DELETE `/loggers` responses.
   - HTTP port probing is inside the HTTP-enabled guard. Unit coverage includes 
an occupied configured port, the pre-startup fallback, and HTTPS-only 
construction with an occupied disabled HTTP port.
   - Updated the operation documentation/test naming and both REST 
documentation languages, including the obsolete dynamic-port cluster-logger 
limitation. The integration test explicitly verifies the shared log directory 
and that the job log exists.
   
   Local OpenJDK 11 validation passed: full-reactor `spotless:apply` and `-q 
-DskipTests verify`, 3 `GetNodeHttpPortOperationTest` tests, and 3 `RestApiIT` 
cases (`testDynamicHttpPortIsResolvableByPeers`, `testLoggers`, `testGetLog`), 
with no test failures or skips.
   
   On your CI question: the old fork run for `d1cf006305aa` was **not green**. 
Run `35829031886` failed in the Windows PayPal test, FilterRowKind transform 
IT, HBase wrapper download (403), and Java 8/11 engine suites; Kudu jobs were 
cancelled. It was not just a stale Apache check or the earlier 
`all-connectors-it-2` report. Shared fixes remain separate in #12454; this PR 
has 8 feature-related files and no workflow changes.
   
   Please take another look at the per-member runtime-port fix. I am monitoring 
the new [Build run](https://github.com/SEZ9/seatunnel/actions/runs/36084725492) 
and will update this comment with its result.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to