DanielLeens commented on PR #12137:
URL: https://github.com/apache/seatunnel/pull/12137#issuecomment-5770816218

   Agreed — that's the right sequencing. My earlier review flagged the same 
thing: the diff against `dev` only bundles #11512's foundation because it's 
unmerged, so validating this slice against that conflicting/cancelled-CI state 
wouldn't tell us anything real. Best to wait for #11512 to land.
   
   @goutamadwant once that happens and you rebase this down to the three files 
it actually owns (`MysqlCdcProgressIT.java`, 
`mysql_cdc_progress_template.conf`, the `pom.xml` test-dependency addition) and 
take it out of draft, I'll do a full pass — including the real MySQL 
restore/progress runs and the binlog-position cross-check @SEZ9 called out. No 
need to ping separately, I'll pick it up once it's ready for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to