SEZ9 commented on PR #11841: URL: https://github.com/apache/seatunnel/pull/11841#issuecomment-5770979869
Thanks for the follow-up commit `961d09d45a`. Re-reading the effective diff against `dev` rather than the earlier `7f55adf8` revision, the reworded `submitJob` comment, the renamed `testSubmitSavepointUsesLegacyParameter`, and the new checkpoint-mode sibling test match what was asked for, and the Option 1 design is preserved. Two small items remain: 1. **Test invariant** – One test still does not quite pin the invariant it is meant to pin. I will flag the exact assertion inline so we can settle it there rather than in this thread. 2. **PR description** – Checkpoint-mode restore submissions that hit a pending cleanup record or existing job metrics are intended to fail rather than follow the savepoint path. Since that is user-visible on upgrade, please spell it out in the PR description (and a release-note line, if you agree). Once those are in I will do a final pass. Thanks for your patience through the long thread. <!-- streview-comment:1229 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
