DanielLeens commented on issue #12434:
URL: https://github.com/apache/seatunnel/issues/12434#issuecomment-5776196914

   Classification: E / Core REST JSON configuration parsing.
   
   Confirmed on current `dev`. The JSON submit path is `RestUtil.buildConfig()` 
-> `JsonUtils.toMap()` -> `ConfigBuilder.of(Map)`, and `ConfigBuilder.of(Map)` 
passes the resulting map directly to `ConfigFactory.parseMap()`. That parser 
treats map keys as HOCON paths, so the literal regex key in 
`multi_table_config.primary_keys` fails before the job is created. 
`RestUtil.buildConfigList()` uses the same path for batch submission.
   
   I found no open PR that fixes this REST JSON path; #12015 documents the 
limitation but does not remediate it. A focused fix is welcome. Please do not 
add a broad catch-and-reparse fallback in the shared `ConfigBuilder` that could 
hide genuinely invalid config paths or change file/HOCON semantics. Prefer a 
narrowly defined literal-key conversion for the REST JSON map shape, or reuse 
the existing configuration-processing path only after proving that its 
resolution, decryption, and masking behavior remains identical for this entry 
point.
   
   Please add deterministic tests for single and batch REST JSON bodies 
covering a nested regex key, ordinary dotted keys such as `job.mode`, and the 
existing secret-decryption/masking flow. The config-file and HOCON REST forms 
must retain their current behavior. Link one focused PR here before 
implementation so this stays a single fix path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to