SEZ9 commented on PR #11545: URL: https://github.com/apache/seatunnel/pull/11545#issuecomment-5826076802
Thanks for the thorough re-review of `50223b3014626c32d00dc79314cabbc3d0e0941a`. You report that F5 (fail-fast Java-version check), F2 (Kerberos reflective reload), F4/F7 (running the old 2.3.13 release on JDK 17), and F1 (launcher-side idempotent flag append) are addressed. I'll walk through the diff for each before marking them resolved; if you can point to the specific changes and verification runs for those, that will speed things up. For F1, a short note in `incompatible-changes.md` that the launcher re-injects the flags would also help operators who have edited `config/jvm_*_options`. Still open: - F3: the `--add-opens`/`--add-exports` flags are still shipped in the production `config/jvm_*_options` files and injected by the launcher, so the blanket opens to ALL-UNNAMED remain. The `jdk9-plus-test-opens` profile only covers the test lane and doesn't change this. - F6/F8: moving the unit-test module-open flags into a JDK-activated Maven profile is the right direction, but as you describe, activating it from the root profile deactivates the default `release` profile, which produces `Could not find the selected project in the reactor: seatunnel-dist`. You also mention the commit between `2c87f42f2b236` and `50223b3014626` only fixed half of it — could you spell out what remains? Asks: 1. Decouple the JDK 17 unit-test module-open flags from the `release` profile's default activation (e.g. activate `release` explicitly where the reactor needs `seatunnel-dist`, or select the flags via a JDK-version property rather than a profile). 2. Once that's fixed, share a green run on plain JDK 11 and JDK 17 without `JAVA_TOOL_OPTIONS` so F6 can be closed. 3. Let me know how you'd like to handle F3 (scoping the production opens to the components that need them, or documenting why the blanket opens are required). Happy to take another look once those are in. <!-- streview-comment:1314 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
