DanielLeens commented on PR #12156:
URL: https://github.com/apache/seatunnel/pull/12156#issuecomment-5846263182
Thanks @SEZ9 — quick clarification plus a status check.
**F4** — this was actually already confirmed in my previous comment, so
nothing was cut off before reaching it. To remove any doubt, here's the Javadoc
again, pulled directly from `PhysicalPlan.java:54-63` on this exact head
(`449b51782`):
```java
/**
* Job states that have not yet started running. Cancelling or stopping a
job in one of these
* states moves it straight to {@link JobStatus#CANCELED} instead of going
through the {@link
* JobStatus#CANCELING} transition, because there is no running work to
drain.
*
* <p>Kept as an explicit status set rather than an ordinal range so that
adding a status in the
* middle of the enum cannot silently change which states are considered
"not started".
*/
private static final Set<JobStatus> NOT_STARTED_STATUSES =
EnumSet.of(JobStatus.INITIALIZING, JobStatus.CREATED,
JobStatus.PENDING);
```
Both call sites (`:221` in `cancelJob()`, `:267` in `stopJob()`) are down to
the single-line `// Not started yet: no running work to drain, so go straight
to CANCELLED.` — no duplicated list of the set's members. So F4 is resolved and
confirmed on this head, same as F1 and F3.
**F2** — you're right that this one is still open. I just re-checked the PR
description again and it's unchanged since my last comment: `Motivation` /
`Changes` / `Verification` / `Fixes #12124`, with no reference to #12342 yet.
@CryoThrust, could you add a line linking the follow-up so the deferred race
stays discoverable from this PR once it merges? That's the one item keeping
this from being fully closed out on my side.
With F1/F3/F4 all confirmed and only the #12342 description link
outstanding, I'm ready to move forward as soon as that's in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
