goutamadwant commented on PR #12481: URL: https://github.com/apache/seatunnel/pull/12481#issuecomment-5848012080
Thanks @SEZ9 @DanielLeens. Addressed in f1527cf9e and c00a8fd81: 1. **Spark and SeaTunnel:** the teardown is now shared in `AbstractTestContainer#stopContainersAndDeleteVolume` ([L156-L175](https://github.com/apache/seatunnel/blob/c00a8fd81d7498adf2521b76fc2b79d41c275afe/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/AbstractTestContainer.java#L156-L175)), used by [Flink](https://github.com/apache/seatunnel/blob/c00a8fd81d7498adf2521b76fc2b79d41c275afe/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/flink/AbstractTestFlinkContainer.java#L165), [Spark](https://github.com/apache/seatunnel/blob/c00a8fd81d7498adf2521b76fc2b79d41c275afe/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/spark/AbstractTestSparkContainer.java#L89) and [SeaTunnel](https://github.com/apache/seatunnel/blob/c00a8fd81d7498adf2521b76fc2b79d41c275afe/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/seatunnel/ SeaTunnelContainer.java#L266). `SeaTunnelContainer` calls `stop()` now; `GenericContainer.close()` only calls `stop()`. 2. **Best-effort `rm -rf`:** a failure is logged as WARN ([L211-L236](https://github.com/apache/seatunnel/blob/c00a8fd81d7498adf2521b76fc2b79d41c275afe/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/AbstractTestContainer.java#L211-L236)). The exit code isn't checked because `rm` always exits 1 on the mount point ("Device or resource busy"). Only `stop()` and host-delete failures are rethrown, and the interrupt flag is kept ([L261-L271](https://github.com/apache/seatunnel/blob/c00a8fd81d7498adf2521b76fc2b79d41c275afe/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/AbstractTestContainer.java#L261-L271)). 3. **Silent skip / host delete:** WARN when the cleanup is skipped and when the host path still exists ([L244-L254](https://github.com/apache/seatunnel/blob/c00a8fd81d7498adf2521b76fc2b79d41c275afe/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/AbstractTestContainer.java#L244-L254)). 4. **Dead stub:** removed; the tests verify `never().execInContainer(...)` ([AbstractTestContainerTest](https://github.com/apache/seatunnel/blob/c00a8fd81d7498adf2521b76fc2b79d41c275afe/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/AbstractTestContainerTest.java)). All 51 `seatunnel-e2e-common` tests pass on JDK 8 and 11. Locally, killing the Spark master, Zeta server or Flink TaskManager and then calling `tearDown()` now removes the container, and the next job passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
