SEZ9 commented on PR #12481:
URL: https://github.com/apache/seatunnel/pull/12481#issuecomment-5851879505

   Thanks @goutamadwant for the follow-up in f1527cf9e and c00a8fd81. The 
approach you describe for the four points (shared 
`AbstractTestContainer#stopContainersAndDeleteVolume` teardown for Flink, Spark 
and SeaTunnel; best-effort `rm -rf` logged at WARN with only `stop()` and 
host-delete failures rethrown; WARN on skipped cleanup and remaining host path; 
`never().execInContainer(...)` verification replacing the dead stub) matches 
what was asked for. I'll go through the diff at c00a8fd81 to verify each point 
against the code and follow up here.
   
   <!-- streview-comment:1336 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to