DanielLeens commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-5881996168
Thanks @SEZ9 — agreed, F1–F8 are closed and nothing further is needed from either of us on the code side. One thing worth flagging before this actually merges, separate from the F1–F8 code discussion: the recorded `Build` check on `7f69d7f69f6` is a real **failure**, not a rendering/mirroring artifact. I pulled the fork's own workflow run for this exact head (`Rangsh/seatunnel` run `34755652767`, matching `head_sha=7f69d7f69f6584165111cf120ac9ffb300b1c8f1`) rather than trusting the mirrored apache-side check, and it completed on 2026-09-13 with `conclusion: failure` across roughly a dozen jobs: `rocketmq-connector-it`, `all-connectors-it-1/2/6/7` (JDK 8 and 11), `paimon-connector-it` (8/11), and `engine-v2-it` (8/11). Given the failure spans that many unrelated connector ITs at once, this reads like CI/infra instability from around that date rather than something this PR's narrow `imap-storage-file`/`WALWorkHandler` diff caused — that change wouldn't plausibly break RocketMQ, Paimon and the general connector suite simultaneously. That said, I did notice `engine-v2-it` failing on a `checkpoint-streaming-enable` job (`sink_file_text_to_assert.conf`) on a row-count assertion (`MIN_ROW` rule expecting >=100, got 80) — since that job exercises checkpoint/streaming behavior overlapping this PR's area, it's worth a clean re-run rather than assuming it's unrelated from log inspection alone. @Rangsh — could you sync the latest `dev` and dispatch a fresh Build on the fork? This head hasn't had CI attempted since 2026-09-13, so the current check predates roughly two weeks of unrelated `dev` changes (including CI-infra fixes). `mergeStateStatus` is currently `BLOCKED`; the F1–F8 review threads are closed, but an actually-green Build for the current head hasn't been confirmed by anyone in this thread yet, and that's a separate, real precondition for merge I don't want to gloss over. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
