Rangsh commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-5787535175
Thanks @DanielLeens for the re-check against `7f69d7f69` — I agree with that reading. @SEZ9 please treat **F1 / F2 / F3 / F4 / F6 / F7** as closed on the current head (same rationale as [Daniel's comment](https://github.com/apache/seatunnel/pull/12081#issuecomment-5787067545)): 1. **F1 / F3** — production callers only use timed `get(timeout, unit)` (`IMapFileStorage` 335 / 376). The untimed `get()` is Future-contract only and is not on a hot path; a stuck/missing WAL completion still surfaces via the caller timeout / shared batch deadline. 2. **F2** — `executeResponse()` is null-checked and wrapped in `try/catch`, so a late or missing future after timeout-and-remove cannot take down the sole disruptor worker. 3. **F4** — intentional fail-close (`appendBlockedAfterWriteFailure`), not reset/reopen; subsequent APPENDs are rejected without touching the stream (landed in `1de6f1b88` / `64b0ec85a`, pinned by survivability tests). 4. **F6** — shared `deadlineNanos` across the batch; whole wait is bounded by one `writDataTimeoutMilliseconds`, not `N ×`. 5. **F7** — method-level Javadoc on `get(timeout, unit)` documents `@throws TimeoutException` (instead of returning `false`). **F5 / F8** remain as already confirmed on `7f69d7f69`. No further code changes planned from my side unless you want a different follow-up on the Error / worker-death path as a separate concern. Happy for you to run the synced-head final pass whenever convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
