SEZ9 commented on PR #12450: URL: https://github.com/apache/seatunnel/pull/12450#issuecomment-5976100677
Thanks @goutamadwant for the follow-up at `4012e59f` — bounding the E2E download retries, keeping exception messages out of the transport-error diagnostic, fixing the EN/ZH MDX notation, and resolving the Windows resource-path / JDK 8 test issues are exactly what I was hoping to see. Switching `WooCommerceMaskingTest.java` to `Paths.get(...toURI())` is the right fix for the cross-platform path problem, and the added `curl` retry flags in `WooCommerceIT.java` close the original E2E-flakiness concern. I also appreciate you keeping the branch current with dev. The delta from `bb6df5c7f3` to `12005b8dd5e` leaves the connector module, the E2E module, and the two `WooCommerce.md` docs unchanged, and the `seatunnel-dist/pom.xml` three-dot diff is just the WooCommerce dependency, so the merges didn't introduce any registration conflicts. Two small things before I merge: 1. You noted you're not claiming CI is green at `4012e59f`. Please ping here once the Build completes on the current head so I can look at the actual result. 2. Could you confirm the three WooCommerce E2E cases still pass locally on the current head (`12005b8dd5e`), not only at `4012e59f`, since the dev merges landed in between? Once those are in, I don't see anything else blocking. <!-- streview-comment:1506 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
