SEZ9 commented on issue #9583:
URL: https://github.com/apache/seatunnel/issues/9583#issuecomment-5988336955

   Thanks @nankeChen75 for digging into this and reproducing it on 2.3.11.
   
   Your analysis matches what the original report hinted at: when `TableFilter` 
drops every input table, `sinkActions` ends up empty and 
`tryGenerateMultiTableSink()` still calls `sinkActions.get(0)`, hence the 
`IndexOutOfBoundsException`. The `sinkActions.isEmpty()` guard you quoted from 
2739847410 is the right fix for that path.
   
   On your two questions:
   
   1. **Fixed in v3.0.0?** For the "all tables filtered out → IndexOutOfBounds" 
failure, yes, the guard you found covers it. What I can't confirm yet is 
whether that is the *only* failure behind this issue: the original report only 
had the error text and full config in screenshots / truncated form, and it 
described the sink being missing from an internal table map, which may or may 
not be the same code path. If you still have your repro, could you paste the 
full stack trace as text (and the complete config, with credentials redacted) 
so we can verify it is the same exception and close this with confidence?
   
   2. **Backport to 2.3.x?** Since you've checked that the guard is absent in 
v2.3.13, a backport makes sense. If you're willing, please open a PR against 
the 2.3.x branch cherry-picking the guard from 2739847410 (plus a small unit 
test for the empty-`sinkActions` case if feasible) and link it here. We'll keep 
this issue open until that lands or until we decide the 2.3.x line won't 
receive it.
   
   One more small ask: in your repro, does the job still behave correctly when 
`TableFilter` keeps *some* but not all tables (i.e. the multi-table sink is 
generated with a reduced table set)? That would help us rule out the "sink 
missing from table map" variant being a separate bug.
   
   <!-- streview-comment:1534 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to