SEZ9 commented on issue #9583:
URL: https://github.com/apache/seatunnel/issues/9583#issuecomment-6030199671

   Thanks for the thorough follow-up, @nankeChen75. The reproduction on 2.3.11 
and the stack trace line up with your analysis: `TableFilter` drops every 
table, `sinkActions` ends up empty, and `tryGenerateMultiTableSink()` still 
calls `sinkActions.get(0)`.
   
   Good to hear the minimal backport based on `2.3.13-release` is already up 
and includes both a parser unit test and a Zeta integration test for the 
all-tables-filtered case.
   
   Two asks to help move the backport along:
   
   1. Please keep the backport scoped to the `sinkActions.isEmpty()` guard from 
2739847410 plus the tests. If you had to deviate from that change for the 2.3.x 
code base, please call it out in the PR description.
   2. Could you confirm that both new tests fail on `2.3.13-release` without 
the guard and pass with it, so they actually pin the regression?
   
   Once those are in place I'll take a look at the PR. Since you noted the 
guard is already present in `dev` and v3.0.0, this issue can stay open to track 
the 2.3.x backport.
   
   <!-- streview-comment:1574 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to