SeaSand1024 commented on PR #12391:
URL: https://github.com/apache/seatunnel/pull/12391#issuecomment-6032306385
@SEZ9 @DanielLeens follow-up on tip `6ad74f1fb` (close-path/tests only).
**1. Classloader assert:** dropped the tautological Awaitility assert in
`testBlockingWorkerFallbackCloseWhenCallAndCloseThrowRuntimeException` — it
compared classloaders on the test thread and could not observe the worker's
nested-`finally` restore. Comment now states that. Production restore unchanged.
**2. F3 / BlockingWorker RuntimeException path:** still covers unchecked
close after the Error-policy change.
`CallAndCloseThrowRuntimeExceptionTask.close()` throws
`RuntimeException("close-fail")`; BlockingWorker fallback still `catch
(Exception)` and logs `Close task error`. Error-policy only widened the
lifecycle loop in `SeaTunnelTask.close()`; the fallback Exception catch is
unchanged.
**3. CI on Build 37460272377 (tip `563fd4e8a`):**
- `all-connectors-it-7 (8)`:
`PostgresCDCIT.testPostgresCdcSnapshotOnlyAndCommittedOffsetStartupModes{TestContainer}[1]`
— expected 1 / got 0 (Zeta). Not close-path.
- `transform-v2-it-part-1 (11)`:
`TestFilterRowKindIT.testFilterRowKindMultiTable{TestContainer}[1]` on
Flink:1.18.0 — expected 0 / got 1. Matches #12116. Not close-path.
Local: BlockingWorker fallback test 1/0/0 after the assert drop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
