SeaSand1024 commented on PR #12391: URL: https://github.com/apache/seatunnel/pull/12391#issuecomment-5965582572
@SEZ9 @DanielLeens F1–F5 addressed on tip `877056bf1` (close-path + tests only). **F1 idempotency:** `AtomicBoolean closed` makes `close()` a no-op on re-entry; `progress.done()` is in `finally` on CLOSED/CANCELLING. Repeated-close test now asserts `times(1)`. **F2 catch narrowing:** lifecycle teardown and BlockingWorker fallback close catch `Exception` only so fatal JVM `Error`s propagate (Error test expects later cycles not closed). **F5 `super.close()` + `allCycles`:** `closeSuper()` + `catch (Exception)`; loop guarded with `if (allCycles != null)`. **F4 Javadoc + log:** `@throws` updated; per-lifecycle log includes `taskLocation` and lifecycle simple name. **F3 tests:** `testClosePreservesSuperCloseFailureAndAttachesLifecycleFailuresAsSuppressed`, null-`allCycles`, CLOSED `progress.done()` on close failure; `testBlockingWorkerFallbackCloseWhenCallAndCloseThrowRuntimeException` for call()+close() both throwing RuntimeException. Local: `SeaTunnelTaskStateTest` — Tests run: 38, Failures: 0, Errors: 0, Skipped: 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
