SEZ9 commented on PR #12511: URL: https://github.com/apache/seatunnel/pull/12511#issuecomment-6050694033
@Vivek1106-04 Thanks for adding the note to part 3 of the PR description — naming `CheckpointErrorRestoreEndTest#testCancelDuringPipelineRestoreWaitEndsTheJobCanceled` for the cancel branch and `SavePointTest#testSavePointFailureDuringPipelineRestoreWaitEndsTheJob` for the non-cancel branch is exactly what I was after, and it makes the `abandonRestore` coverage easy to find for anyone reading the PR later. Nothing more needed from me on that point. Understood that the code is unchanged since `a691fb195`, so the green run you reported there (attempt 2 passing `engine-v2-it (11)` and the rest of the engine jobs) still stands. The pointer to https://github.com/apache/seatunnel/pull/12511#issuecomment-5982000557 also clears up the truncated first comment and the Issue 4 coverage for me. From my side the previously raised items are resolved and I have no remaining asks. I'll do a final pass over the description as updated and then move forward with this. <!-- streview-comment:1582 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
