chovy-3012 commented on PR #12703: URL: https://github.com/apache/seatunnel/pull/12703#issuecomment-6105475123
Thanks for the thorough review! All items addressed: **Issue 1 (timezone contract):** Added a non-UTC test case under `Asia/Shanghai` — string input asserts `1672502400` (CST, not `1672531200`), `OffsetDateTime` asserts `1672531200` (zone-independent). Also added a zone-independent round-trip in the E2E (`from_unixtime(unix_timestamp(c2)) = c2`). **Issue 2 (impossible dates, Option A):** Kept the SMART resolver clamping behavior. Documented in Javadoc and EN/ZH docs. Added a test case pinning the clamped value (`2023-02-30` → `1677542400` under UTC). **Issue 3 (E2E NOT_NULL):** Added `rt2 = from_unixtime(unix_timestamp(c2), 'yyyy-MM-dd HH:mm:ss')` with `equals_to = "2023-01-01 00:00:00"` — a zone-independent exact-value assertion. **Issue 4 (per-row formatter):** Added a `ConcurrentHashMap`-backed formatter cache (`FORMATTER_CACHE`) shared by `unixTimestamp` and `fromUnixTime`. **Issue 5 (UDF shadowing):** Added a note in both EN/ZH docs that a same-named UDF is shadowed by the built-in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
