DanielLeens commented on PR #12703: URL: https://github.com/apache/seatunnel/pull/12703#issuecomment-6135241697
Thanks @chovy-3012. A quick CI update, because my last review described the fork `Build` run for head `3df0352b9dfc` as still queued. That run has now finished with `failure` (fork run 38185671979, apache-side `Build` is red). The failed jobs are `engine-v2-it` (Java 8 and 11), `all-connectors-it-7 (11)` and `elasticsearch-connector-it` (Java 8 and 11). None of these exercise the SQL transform path touched here (the SQL-relevant lanes were green in the earlier run), so the failures look unrelated to this diff. This is an inference from the lane names, and I have not yet opened the individual job logs. Please re-run only the failed jobs rather than the whole workflow. Separately, @SEZ9 posted a full review on the same head after mine, with eight follow-up items (for example the `getFormatter(pattern)` call sitting outside the `try`, the docs/incompatible-changes notes, and the E2E assertions that are only `NOT_NULL`). I have not re-verified them in this CI follow-up, so please treat them as the open source-side items for this PR. I will fold them into my full re-review once a new commit is pushed, and I would not treat this PR as ready until they are addressed or answered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
