SEPURI-SAI-KRISHNA commented on PR #12495:
URL: https://github.com/apache/seatunnel/pull/12495#issuecomment-6106556527
One note on N1, @DanielLeens: those two Calcite sites are already fixed, in
#12618, which you reviewed and approved on 2026-10-09. Flagging it so nobody
reading this thread later treats it as outstanding work.
Both lines you named are in that diff:
```text
calcite/udf/BuiltinFunctions.java
- String name = rawName.toUpperCase();
+ String name = rawName.toUpperCase(Locale.ROOT);
calcite/udf/VectorReduceFunction.java
- switch (method.toUpperCase()) {
+ switch (method.toUpperCase(Locale.ROOT)) {
```
#12618 covers all eleven sites in `calcite`, `nlpmodel` and `validator`, and
`VectorReduceFunction` is one of the three it classifies as a
production-reachable defect rather than hardening, because the `switch` needs
an exact match and `RANDOM_PROJECTION` carries an `i`.
`CalciteSQLEngineTest.testVectorReduceMethodIsLocaleIndependent` pins it under
`tr-TR`.
So the split across the two PRs is: this one takes the 13 sites under
`sql/`, #12618 takes the 11 under the other three packages, and together they
take the module to zero bare conversions. That is the 13 + 11 = 24 arithmetic
against the #12620 baseline.
No change needed here, and nothing else outstanding from your review on this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
