DanielLeens commented on PR #12495: URL: https://github.com/apache/seatunnel/pull/12495#issuecomment-6109439087
Thanks for the careful follow-up, and for spelling out the split between the two PRs. I checked the diff of #12618 and both sites I called out in N1 (`BuiltinFunctions.java`, `rawName.toUpperCase(Locale.ROOT)`, and `VectorReduceFunction.java`, `switch (method.toUpperCase(Locale.ROOT))`) are indeed converted there, so N1 is already covered and is not outstanding work for this PR. Please treat it as withdrawn on #12495; sorry for the noise. With that, I have nothing else open from my review on this PR. The remaining gate is CI on the current head (rerunning only the failed jobs after syncing the latest `dev` is the cheapest next step). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
