Rangsh commented on PR #12662: URL: https://github.com/apache/seatunnel/pull/12662#issuecomment-6115810019
Thanks @DanielLeens. The rebased head is ready locally, but I cannot push it: this branch lives in @SwatiKumari250's fork, and a permission check against that fork returns 403. I have not opened a replacement PR. Local commit: `6ef132fee85bbc7e8184de62fc4bf27d4318ca2a` - Parent is current `dev` (`83603e19b7b09d6114c6f6c9e89bfdafe2796183`). - Author remains `SwatiKumari250 <[email protected]>`. - The only change is `seatunnel-connectors-v2/connector-lance/pom.xml`: the module-level Surefire `<argLine>`, the `java9+` profile, and the `darwin-aarch64-java9+` profile are removed. `darwin-aarch64` keeps only `-Dos.arch=aarch64 -Dos.name=Mac OS X`. JDK 17 verification on macOS ARM, with the CLI property deliberately excluding `--add-opens`: ```bash ./mvnw -pl seatunnel-connectors-v2/connector-lance -am test \ -Dsurefire.jvm.args="-Dfile.encoding=UTF-8" \ -Dskip.spotless=true \ -Dsurefire.failIfNoSpecifiedTests=false \ -Dtest='!org.apache.seatunnel.api.table.catalog.schema.ReadonlyConfigParserTest' ``` `BUILD SUCCESS` at 2026-10-12T08:43:45+08:00. `connector-lance`: Tests run: 28, Failures: 0, Errors: 0, Skipped: 0. The Surefire reports show `java.specification.version=17`, `os.name=Mac OS X`, `os.arch=aarch64`, and `surefire.jvm.args=-Dfile.encoding=UTF-8`, so `--add-opens=java.base/java.nio=ALL-UNNAMED` comes from the root `${surefire.module.args}`. @SwatiKumari250 could you please: 1. Confirm that I may update this branch. 2. Enable GitHub Actions in your fork so CI can run. 3. Push `6ef132fee85bbc7e8184de62fc4bf27d4318ca2a` to `fix/connector-lance-surefire-argline-12655` (I can provide the commit/patch immediately), or grant me push access. 4. Update the title to `[Improve][Connector-V2] Fix connector-lance Surefire argLine inheritance` and fill in the description. I cannot edit either as a non-author. The local-override scan and `backend.yml` cleanup remain a separate follow-up, as agreed. @DanielLeens, the full re-review can happen once this commit is actually on the PR head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
