DanielLeens commented on PR #12662:
URL: https://github.com/apache/seatunnel/pull/12662#issuecomment-6116680119
Thanks @Rangsh, this is exactly the final shape I was hoping for, and the
JDK 17 evidence (28 tests, `surefire.jvm.args=-Dfile.encoding=UTF-8` with
`--add-opens` arriving via the root `${surefire.module.args}`) closes my
finding 4 once it is attached to the PR. Also thanks for not opening a
replacement PR.
Status: the PR head is still `5e17b58c698f` (checked just now), so
`6ef132fe` is not on the PR yet and I will do the full re-review only after it
is. The author owns the fork branch, so a push from you is indeed not possible
(and there is no way to make GitHub accept a PR-head update without push access
to that fork branch).
Concrete next steps, in order:
1. @SwatiKumari250, the quickest path is for you to apply Rangsh's commit on
your branch. Rangsh, please publish `6ef132fe` on a branch in your own fork (or
attach the `git format-patch` output as a comment) so she can run `git fetch
<your-fork> <branch>` and `git reset --hard FETCH_HEAD` on
`fix/connector-lance-surefire-argline-12655`, then push. That keeps her
authorship and gives the PR the exact rebased commit.
2. @SwatiKumari250, please also enable GitHub Actions in your fork (Actions
tab, then "I understand my workflows, go ahead and enable them"); only the fork
owner can do this, and without it the apache-side `Build` check stays
`ACTION_REQUIRED`. Then update the title to `[Improve][Connector-V2] Fix
connector-lance Surefire argLine inheritance` and paste the description
(Rangsh's verification block can be reused as is).
3. Fallback so this does not stall: if there is no response from the author
within about 5 days, I am fine with Rangsh opening a new PR from the same
commit (it already keeps Swati's authorship, so she remains credited in
history), with a link to this PR, and we close this one as superseded. That
would be the one exception to the single-implementation agreement, and only
because the author branch cannot be updated.
The local-override scan and `backend.yml` cleanup stay as the separate
follow-up. Thanks both for coordinating so nicely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
