zhangshenghang commented on PR #11781: URL: https://github.com/apache/seatunnel/pull/11781#issuecomment-6117244001
Thanks @SEZ9 — addressed on head `99827177`: **Item 1 (F1/F3)**: Added `testLegacyMappingsTargetCurrentClassNames`, which binds every `LEGACY_CLASS_NAME_MAPPINGS` target to the live `engine-common` class via compile-time references (`JobStatus.class.getName()` etc.), so a future rename of a target class now fails the build instead of silently breaking the shim. The three-name coverage with real deserialized-value assertions (`JobStatus` by enum name, `JobResult` by status/error fields, `JobStatusData` by all six fields) was already in place at `452cd144`. **Item 2 (F2)**: Already satisfied on the current head — the `ClassNotFoundException` handler throws `IMapStorageException` with both the original name and `resolveClassName(className)` in the message. **Nice-to-haves**: F3 — `incompatible-changes.md` (en/zh) already carries the #9689 relocation entry including the one-directional downgrade semantics. F4 — added the explanatory pom comment. F5 — will handle as a follow-up if still wanted. F6 — clarified the javadoc: resolution is single-level; chained relocations need an entry per intermediate name. Spotless clean, `WALReaderAndWriterTest` 8/8 green locally. Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
