zhangshenghang commented on PR #11781: URL: https://github.com/apache/seatunnel/pull/11781#issuecomment-6160039440
Hi @SEZ9, both asks are done: - **TODO note**: added on `f6869ab0` — a short comment on `LEGACY_JOB_STATUS_PATH` in `WALReaderAndWriterTest.java` stating that the fixtures are generated by the current `WALWriter` (only the recorded class-name strings are pre-#9689) and that replaying a frame actually written by a pre-relocation release is planned as a follow-up. - **Follow-up issue**: will open it and link it back here once this lands. On the earlier items, where things stand on the current head: - **F1/F3**: `testReaderLoadsAllLegacyJobModelClassNames` writes all three legacy names and asserts on the deserialized values — the enum value via `name()` for `JobStatus`, `getStatus().name()` plus the error string for `JobResult`, and the class for `JobStatusData`. `testLegacyMappingsTargetCurrentClassNames` binds every `LEGACY_CLASS_NAME_MAPPINGS` target to the live class via `JobStatus.class.getName()` etc., so the string literals in `WALReader.java` are verified by a test rather than left unchecked. - **F2**: `testUnknownClassNameSurfacesInExceptionMessage` replays a record whose value class is `org.apache.seatunnel.engine.core.job.NeverExistedJobStatus` and asserts the `IMapStorageException` message contains both the recorded name and the resolved name. - **F4/F5**: both `incompatible-changes.md` (en/zh) carry the entry describing the #9689 relocation, the transparent rewrite on read, and the one-directional downgrade caveat. - **F6**: the test-scoped `seatunnel-engine-common` dependency in `imap-storage-file/pom.xml` has the comment explaining why production code references the class names as strings. - **F8**: `resolveClassName` is a single-hop `getOrDefault`, and the `LEGACY_CLASS_NAME_MAPPINGS` Javadoc documents resolution as single-level with one entry per legacy name, as we agreed. These landed across `446ae128` → `9658666b`; the only newer commits are `dev` merges and the TODO note above. The full CI run on `6c771bdd` was green (24 passed, 6 skipped by path filters), and `f6869ab0` has just re-triggered the pipeline — it is a comment-only change. Thanks for the careful review, happy to get the final pass whenever you have a moment! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
