SEZ9 commented on PR #12595: URL: https://github.com/apache/seatunnel/pull/12595#issuecomment-6137651935
Thanks @SEPURI-SAI-KRISHNA, this is a thorough write-up and I agree with the reading. On the earlier Issue 1: your check that JDK 8 carries the same time-constant `MessageDigest.isEqual` implementation settles that point, so it is closed from my side. Nothing else is open on `BasicAuthFilter` or its two tests. On the CI analysis: - `TestFilterRowKindIT`: agreed, with the `#12116` / `#12216` link and all four `transform-v2-it` jobs green after the `dev` sync, that one is resolved rather than lucky. - `CassandraIT`: your narrowing is convincing. Both failures sitting on the first `assertEquals(0, execResult.getExitCode())` means the job itself exited 1 before the test touched Cassandra, and the same `[2]` invocation failing identically on the JDK 11 and JDK 17 legs in ~32-36s is not a race pattern. I also agree it cannot be attributed to this PR: the diff is the filter plus tests, `enable-basic-auth` defaults to `false`, and the Cassandra e2e path submits via the container CLI, not the REST filter. - `DatabendCDCSinkIT`: fine to treat as the known signature listed in `#12482`, with the caveat you noted that `#12482` is a matrix proposal rather than a bug report. Two small asks so this does not get lost once the PR is merged: 1. If the failsafe report or the parameterized test display name lets you map invocation `[2]` to a concrete engine, please add that to your comment. If it is not recoverable from the artifacts, say so and I will not hold on it. 2. Since no existing issue names `CassandraIT`, please open one with the exit-code detail and the `[2]`-only pattern you pasted here, and link it back on this thread. That gives the `dev` failure its own home instead of living in this PR's history. Nothing further needed on the code itself. <!-- streview-comment:1717 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
