DanielLeens commented on PR #11988: URL: https://github.com/apache/seatunnel/pull/11988#issuecomment-6138706864
Addressed the remaining review blockers on head `ec87c8fcff3`: - Synced current `apache/dev` with a merge commit (rather than rebasing/force-pushing) and resolved the sole conflict in `MySqlIncrementalSourceFactory` by preserving both the current specific-offset guards and the `mixed`-mode constraints. The PR is now conflict-free. - Added `MysqlCDCSpecificStartingOffsetIT#testMysqlCdcMixedStartupWithRestore` plus `mysqlcdc_mixed_startup.conf`. The test uses two tables: the selected table must include its pre-offset snapshot and later binlog changes, while the non-selected table must exclude its pre-offset row and include only rows at/after the configured offset. It then takes a savepoint, restores the same job, writes to both tables again, and asserts that both policies remain intact. - Ran Spotless apply for `connector-cdc-mysql` and `connector-cdc-mysql-e2e`; it passed. Per the repository rule, compile/unit/E2E execution is left to GitHub CI on this head. The new Build is queued: https://github.com/DanielLeens/seatunnel/actions/runs/38349930278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
