DanielLeens commented on issue #12753: URL: https://github.com/apache/seatunnel/issues/12753#issuecomment-6145194118
The source-schema defect is confirmed on current `dev`: `AbstractDorisTypeConverter` declares LARGEINT as `DECIMAL(20,0)`, while the Doris-to-Doris special case only protects that one target path. A generic sink that relies on the logical schema can therefore receive an undersized decimal. Please use the exact source representation, `DECIMAL(39,0)`, for scalar LARGEINT and the corresponding array element type. Do not silently change the source schema to STRING or clamp it to 38 digits to accommodate a target-specific limit. Target connectors that cannot represent `DECIMAL(39,0)` need their own explicit compatibility behavior; this PR should not promise lossless delivery to every target. Please include source-schema tests for 21-digit values and both signed 128-bit extrema, array coverage, and an end-to-end Doris-to-MySQL auto-create regression showing that the full positive range is no longer narrowed. Also retain the existing Doris-to-Doris source-type preservation. The 40-character requirement applies only to a future bounded-string fallback because the minus sign is not decimal precision. Please link the focused PR here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
