SEZ9 commented on issue #12753:
URL: https://github.com/apache/seatunnel/issues/12753#issuecomment-6183710359

   Thanks for the detailed report and reproduction.
   
   The source-side analysis holds: `AbstractDorisTypeConverter#convert` 
declares `LARGEINT` as `DecimalType(20, 0)`, which cannot hold the 128-bit 
range, and the Doris → Doris path only works because of the `sourceType = 
largeint` special case in `reconvert()`. Mapping scalar `LARGEINT` and the 
`ARRAY<largeint>` element type to `DECIMAL(39,0)`, while keeping the Doris → 
Doris preservation, still looks like the right source-schema correction. That 
does not promise lossless delivery to every sink; targets that cannot represent 
39 digits should handle that explicitly in their own converters rather than by 
narrowing the source schema.
   
   If you run into any engine- or sink-level precision limits while 
implementing this, please describe them in the PR (which component raises the 
error and at which stage) so we can decide how to handle them, rather than 
silently clamping. Please link the PR here once it is open.
   
   <!-- streview-comment:1771 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to