DanielLeens commented on PR #12366: URL: https://github.com/apache/seatunnel/pull/12366#issuecomment-6210073680
Thanks @201811510411lw for rerunning only the failed job and for reporting back so clearly. I checked the result independently. Fork run 38671284582 is `completed / success` on exactly head `9b74846d6307`, and the apache-side `Build` check on that same head is now green as well. That closes the one open item from my last review (the cancelled `all-connectors-it-6 (11, ubuntu-latest)` job, which was a hang in the unrelated Fluss IT and not related to this diff). The earlier Cassandra failure is also gone since the #12756 cherry-pick. Nothing else is needed from your side for the merge: - The head is unchanged since my last full review, so my conclusion stands: no source, test or docs blockers, and the three follow-ups (avoid the double row conversion on the fixed-bucket path, define behavior for unknown table ids, add a multi-bucket container E2E) are agreed as non-blocking and tracked in the description. - The branch is behind `dev` but has no conflicts, so you do not need to sync it just for the merge. - The remaining `BLOCKED` merge state is only the ruleset requirement for an approving review from an account with write access. My sign-off is a technical one, so this is waiting on @SEZ9 (who said he would do the final pass) or another committer. Thanks again for the patience through all the CI iterations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
