SEZ9 commented on PR #12443: URL: https://github.com/apache/seatunnel/pull/12443#issuecomment-6229080238
Thanks for the update on `bdcfccdb1b80`. Picking up from the previous review, the only item still open is **F4 (REST-level test coverage)**. Good to see `RestApiIT` now carries `testSubmitJobWithHoconFormatAndQuotedLiteralKey` and `testSubmitJobWithJsonFormat`. What is still missing is an actual run of those cases against this head. Either of the following would close this out: - a CI run on `bdcfccdb1b80` that includes `RestApiIT`, or - a local run of `RestApiIT` (for example `./mvnw -pl seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base -am verify -Dit.test=RestApiIT`) with the result pasted into the PR description. Once that evidence is in, I'm happy to take another look. <!-- streview-comment:1824 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
