karthik-0306 commented on issue #12707: URL: https://github.com/apache/seatunnel/issues/12707#issuecomment-6240615267
Hi @SEZ9, #12740 (Java detection) is now merged. Thanks to you, @DanielLeens and @CryoThrust for the reviews and testing. I'd like to keep working on PR 1 from your split, one small piece at a time. Two proposals: 1. CI for the SDK tests. No workflow runs the tools/seatunnel-python-sdk tests today (DanielLeens pointed this out in #12740). I can add a small path-filtered workflow, similar to cli.yml, that runs pytest on Python 3.9 and the latest 3.x. It would cover the existing test_sdk.py and the new detector tests. 2. install-plugin support. This would rewrite config/plugin_config down to the requested connectors, keep the section headers, and give the same result when run twice. Then it calls bin/install-plugin.sh <version>. It would be its own module with mocked pytest tests, like the Java detector. Later on I'd also be glad to help with the local-run path and the seatunnel.run(...) Python API, if that works for you. If you're already working on any of these, or would rather I pick up another piece (like the per-user cache directory or the checkpoint config override), just let me know so we don't duplicate work. Each PR will be small and linked back here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
