SEZ9 commented on issue #12707: URL: https://github.com/apache/seatunnel/issues/12707#issuecomment-6244656131
Thanks for the follow-up, and for wrapping up the Java detection PR with the JAVA_HOME value and the fix/unset hint in the error plus the accompanying test — that covers both of the asks I had on that point, so I consider it closed from my side. Thanks also to @CryoThrust for running the detector tests and exercising it against installed JDKs. On your two proposals: I'm not working on either of them, so there's no risk of duplication — please go ahead. 1. CI for the SDK tests: yes, a small path-filtered workflow that runs pytest on Python 3.9 and the latest 3.x, covering the existing `test_sdk.py` and the new detector tests, sounds right. Keep it minimal and scoped to the SDK path. 2. install-plugin support: agreed on the shape — its own module, rewrite `config/plugin_config` to the requested connectors while preserving section headers, idempotent on a second run, then call `bin/install-plugin.sh <version>`, with mocked pytest tests like the Java detector. Please open them as separate small PRs and link each back here, same as you did for the detector. Once those two land we can talk about the local-run path and the `seatunnel.run(...)` API; I'd rather sequence them one at a time than start on those in parallel. <!-- streview-comment:1832 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
