SEZ9 commented on issue #12763: URL: https://github.com/apache/seatunnel/issues/12763#issuecomment-6282251267
Thanks @goutamadwant for reproducing the `Unsupported format version: v3` failure on Iceberg 1.6.1 and for splitting the work into phases — the plan looks good to me. A few notes on where things stand: - **Phase 1** (Iceberg 1.10.2 upgrade, v3 table creation, `timestamp_ns`/`unknown` type mapping, docs): this is the core of what this issue asked for, so let's keep that PR focused on the dependency bump and the new type mapping so it can land first. - **Phase 2** (deletion vectors in the upsert/CDC writer, replay-safe commits, v2 compatibility): the build on that PR is currently failing, so nothing there is accepted yet. Please get CI green, and keep the recovery-test evidence and the explicit v2 compatibility cases in the PR — those are what will let us verify the v3 writer path does not regress existing v2 tables. - **Phases 3 and 4** (`variant`, column defaults, row-lineage columns, incremental v3 reads; multi-argument partition/sort transforms): agreed these should stay as separate follow-ups rather than being folded into the phase-2 PR. Concrete asks: 1. Fix the CI failure on the phase-2 PR and ping back here once it passes. 2. Confirm in the phase-1 PR description which v3 types are mapped now and which are deferred to phase 3, so reviewers can check the mapping against the list. @nzw921rx — once phase 1 is merged, it would be great if you could try creating a `format-version = 3` table against a build from that branch and report back whether your original scenario works. <!-- streview-comment:1892 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
