Rangsh commented on PR #12173:
URL: https://github.com/apache/seatunnel/pull/12173#issuecomment-6284962934
@SEZ9 answers on `b137173f7`, no new push.
1. **F4 — intentional.** Javadoc is the source of truth for the sampling
window. `docs/en|zh/engines/zeta/benchmark.md` should not get even a one-line
note.
The growth-scenario notes were added in `909f87840` and removed in
`9a6077c58`, after @nzw921rx's 2026-09-10 `CHANGES_REQUESTED`: the benchmark
docs had been refactored and this scenario should not be added back.
`b137173f7` does not touch either page. The whole current diff vs the
merge-base is only:
- `IMapJobStorageBenchmark.java`
- `IMapJobGrowthBenchmarkWorkload.java`
- `JobHistoryService.java`
- `JobHistoryServiceFinishedMetricsTest.java`
2. **F2 / F5 / F6 — unchanged.** `b137173f7` does not touch
`JobHistoryService` or `JobHistoryServiceFinishedMetricsTest`. Both files are
byte-identical to `ca82f95d3b`, and also to `909f878402`, `c0d59da54`, and
`7948e2640`. The last commit that changed either file is `ca82f95d3b`.
Please re-confirm F1–F6 against `b137173f7`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
