Rangsh commented on PR #12173:
URL: https://github.com/apache/seatunnel/pull/12173#issuecomment-6331374358
@SEZ9 F6, restating the part that got cut off. No new push.
Both paths are covered in `JobHistoryServiceFinishedMetricsTest`:
- **Null metrics:** `storeFinishedPipelineMetricsRejectsNullMetrics`
(`JobHistoryServiceFinishedMetricsTest.java:135-138`) expects
`NullPointerException` and calls `storeFinishedPipelineMetrics(1L, null)`.
- **TTL-preserving `put`:** all three success paths verify `put(eq(1L),
any(), eq(1440L), eq(TimeUnit.MINUTES))`:
- `storeFinishedPipelineMetricsWritesOnceForNewJob` (`:100-105`)
- `storeFinishedPipelineMetricsMergesExistingFinishedMetrics` (`:121-126`)
- `storeFinishedPipelineMetricsKeepsExistingMetricsForOtherTags`
(`:155-160`)
`FINISHED_JOB_EXPIRE_MINUTES` is `1440L` at `:57`. None of these tests use
`computeIfAbsent`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
