fatmanverse commented on PR #11487: URL: https://github.com/apache/seatunnel/pull/11487#issuecomment-6306263410
Thanks @DanielLeens for the re-review. - **Issue 1 (OceanBase-CDC):** 39c796a adds `testOptionRuleInheritsSnapshotOnlyGuards` to `OceanBaseIncrementalSourceFactoryTest` (a plain `snapshot-only` config is accepted, and `stop.mode = latest` is rejected by the inherited guard), plus a line in the en/zh `OceanBase-CDC.md` constraints that links to the MySQL-CDC snapshot-only section. Verified on JDK 17: `spotless:check` and the `connector-cdc-oceanbase` unit tests (10/10 pass). - **Issue 2 (CI):** the Build failure is `LLMBooleanOutputTest.readsLegacyFactoryWrapperWithValidationDisabled` on `dev` (#12929), unrelated to this PR. I will re-run the failed jobs once `dev` is fixed and confirm the CDC unit tests and `mysql-cdc-connector-it` pass. @nzw921rx The optionRule migration you suggested landed in d28296a (`MySqlSnapshotOnlyGuards` under `conditional(startup.mode, snapshot-only)`, base-class check removed). Could you take another look and update your review when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
