DanielLeens commented on PR #11487:
URL: https://github.com/apache/seatunnel/pull/11487#issuecomment-6338498689

   Thanks @SEZ9. I checked the MySQL documentation itself on `39c796a2ee6f`, 
not just the last commit's OceanBase delta. The requested MySQL material is 
already present earlier in this head:
   
   - **F1/F6:** EN MySQL-CDC.md:549 explicitly documents reader-start-time 
range validation, `start + subtask index`, and MySQL terminating an earlier 
connection on duplicate server id. This is a stated limitation, not a claim 
that submission validates parallelism.
   - **F2:** lines 544-547 distinguish plain per-split reads without backfill 
from exactly-once low/high-watermark backfill, including the absence of a 
global point-in-time guarantee.
   - **F3:** the file/position/GTID/timestamp option rows at 197-202 explicitly 
mention snapshot-only rejection, and the stop.mode row names the never-only 
constraint. The skip-events/skip-rows rows remain scoped to specific mode; any 
further wording there would be documentation polish, not evidence those offset 
modes are supported in snapshot-only.
   - **F4:** the ZH exactly_once row is at 219; the bounded-snapshot 
consistency/range discussion is at 532-541, with the initial-mode FAQ at 691.
   - **F5/F7:** the snapshot-only example uses `${mysql_password}` at 563, 
enables exactly_once at 566 and gives the parallelism-2 range at 567. Older 
unrelated examples elsewhere still use their example credentials.
   - **F8:** the initial-mode FAQ at 702 explicitly retains the resume position 
recorded at snapshot start, then separately states that snapshot-only never 
enters continuous streaming.
   
   I would not ask the author to repeat these edits. This is a targeted answer 
on the existing head; no new full review or local execution was performed. My 
source conclusion remains clear, while your final direct check is still yours. 
Build is failed on the unrelated LLM archived-fixture path; #12938 remains open 
and current dev has not incorporated it. Once it lands, sync and rerun failed 
jobs so CDC unit tests actually execute. Final required CI and a write-capable 
maintainer approval remain necessary.
   
   Current status evidence: head `39c796a2ee6f53ecb0740a4c62aff71e15c44db8`, 
base `dev`, compare `diverged` (ahead 16, behind 10), mergeable state `blocked`.
   
   CI references: [current Build 
check](https://github.com/apache/seatunnel/runs/119007089029).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to