SEZ9 commented on PR #11500: URL: https://github.com/apache/seatunnel/pull/11500#issuecomment-6378676139
@zhangshenghang thanks for the update on `e3dcf1c48..fe8b1b39c`. Going through the previous points, here is what I still need to see in the diff before closing them: - **F2 / F3** — you mention the local-mode cap and restore re-evaluation sentences are present in the en `incompatible-changes.md` entry and mirrored in zh. Could you point me to the hunk in this PR that adds them? I'd like to verify against the diff rather than the description. - **F5** — the rewording that makes the *mode* the default and `slot-num` an example is what I asked for. Please also confirm the zh k8s configuration guide received the same rewording as its en counterpart; I'll re-check the zh intro-paragraph fix in `fe8b1b39c` when I look at the diff. - **F6** — your comment was cut off at "The PR descr…". Please confirm the `setNullToStatementByDataType` paragraph is removed from the PR description. - **F1** — not covered in your update. Both existing `isDynamicSlot()` assertions load YAMLs that set `dynamic-slot: false` explicitly; please add one that loads a config with no `dynamic-slot` key and asserts `isDynamicSlot()` is `false`, so the flipped default is actually exercised. - **F4** — please confirm the full `Example` block in section 4.3 of the separated-cluster deployment page (en + zh) no longer ships `dynamic-slot: true`, matching the hybrid page. Happy to take another pass once these are in. <!-- streview-comment:1986 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
