DanielLeens commented on PR #11500: URL: https://github.com/apache/seatunnel/pull/11500#issuecomment-6396816671
Thanks, @SEZ9. I checked the two specific questions at `94209409a6a1635ed8887a0d0615b49295c58bd8` with local source/resource inspection: - The shared engine E2E fixture still explicitly sets `dynamic-slot: true` (`connector-seatunnel-e2e-base/src/test/resources/seatunnel.yaml:26`). However, this PR also gives `KubernetesIT` a custom `seatunnel.yaml` with `slot-num: 8` and deliberately no `dynamic-slot` key; its `slot-service` block exercises the changed static default. This is a dedicated static-default lane, not a claim that the whole shared suite has switched modes. I inspected that wiring, not ran the Kubernetes test locally. - Both English static-slot examples already say `slot-num: 20 # optional; defaults to 2 x CPU cores when omitted` (`hybrid-cluster-deployment.md:67`, `separated-cluster-deployment.md:120`), and the Chinese examples have matching notes at lines 68/126. Thus 20 is an explicit example value, not the omitted-value default. Dropping the optional value would be another valid presentation, but the requested clarification is already present in this head. This addresses those discussion questions only; your independent finding closeout and final maintainer approval remain yours to complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
