SEZ9 commented on PR #12079: URL: https://github.com/apache/seatunnel/pull/12079#issuecomment-6379351669
Thanks for the rebase. Comparing `b190936bbbcb` with `3696a4b3c07d`, the PR-owned source, test and E2E files are unchanged and only the incompatible-changes doc picked up unrelated entries from dev, so here is where my earlier points stand on this head. **Addressed** - **F1:** each output ID releases its waiters exactly once, so duplicate output IDs can no longer release a multi-input transform early. - **F3 / F5:** dry-run and runtime now share the single `TransformDependencyScheduler`, so the two paths cannot diverge. - **F6:** cycle detection runs after the ready loop and before the fallbacks are applied, so a self-cycle no longer slips through the legacy fallback. - **F7:** the behavior change is documented in the en and zh incompatible-changes entries. - **F2 / F4:** the narrowed fallback is an intentional, documented incompatibility, and the two remaining fallbacks are spelled out in the scheduler, so I consider this settled. **One remaining question** - **F8:** is the unused `getOutputId()` accessor still present, and has the input/output ID resolution been consolidated onto the existing helpers instead of re-parsing `ReadonlyConfig`? A short note either way is fine. Otherwise this looks good to me. <!-- streview-comment:1994 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
