DanielLeens commented on PR #12079: URL: https://github.com/apache/seatunnel/pull/12079#issuecomment-6466884997
Thanks @SEZ9, and for taking the time to go through the diff on this head (`9152a91fa278`). Answers to your two questions (static read only, nothing run locally): 1. **The "cut off" sentence.** My previous comment is not truncated. The open item is simply the missing contract comments: `ConfigParserUtil.getInputIds` (now `public`) and the new `DryRunConnectValidator.scheduleTransforms` wrapper have no Javadoc on this head. The Javadoc should say that an omitted `plugin_input` defaults to the default ID, which is different from an explicit empty list, and that the wrapper only translates `JobDefineCheckException` into `ConfigCheckException`. It is comment-only, no algorithm change, and I would like it to land in this PR since the method visibility is changed here. @goutamadwant, could you add it when you next push? 2. **Where runtime and dry-run converge.** Both go through one implementation, `TransformDependencyScheduler.scheduleTransforms(...)` in `seatunnel-engine-core` (`org.apache.seatunnel.engine.core.parse`). The runtime path, `MultipleTableJobConfigParser#parseTransforms`, calls it directly (static import) with the transform configs and the current table keys, then iterates the returned `ScheduledTransform` list. The dry-run path, `DryRunConnectValidator.scheduleTransforms`, is a thin wrapper that calls the same method and only rethrows the failure as `ConfigCheckException`. Input IDs for both come from `ConfigParserUtil.getInputIds` via `ScheduledTransform`, so there is no second ready-queue or second resolver left in the diff. That is also why the unit tests in `ConfigParserUtilTest` exercise the scheduler once and the dry-run and runtime tests only check the wrapper and the parser behaviour. I will re-verify once the Javadoc commit lands. The current `Build` run for this head was still in progress when I looked, so CI status is not yet confirmed either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
