DanielLeens commented on PR #12578: URL: https://github.com/apache/seatunnel/pull/12578#issuecomment-6396711595
Thanks @hutiefang76 for the exact locations, and thanks @SEZ9 for separating source follow-ups from CI. I checked `SeaTunnelRow.java:52-61` on unchanged `ef53a70c`: `setField` now invalidates under `if (size != 0)`, and its Javadoc explicitly excludes direct `getFields()` writes and nested mutations. That answers the unconditional-volatile-write concern for this head. Please assess the referenced overload/nested-mutation tests as the stated boundary contract, rather than expecting them to make nested mutations invalidate automatically. The remaining failed engine IT and missing PR-bound check must be handled as the separate CI gates already discussed; no unrelated source patch is requested for them. My source conclusion remains unchanged, and I am leaving your own final verification/threads to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
