SEZ9 commented on PR #12578: URL: https://github.com/apache/seatunnel/pull/12578#issuecomment-6406679665
@hutiefang76 thanks for the pointers to `ef53a70c`. Your description lines up with what F1, F2, F3 and F5 asked for, but I have not yet been able to confirm the changes against the diff itself, so I am holding off on marking them resolved until I have done that. Two things I would appreciate before I close them out: - Your comment appears to have been cut off after "check that explicitly calling the parent setter invalid". Could you post the rest of the F3/F5 point? - For F4 (typed pre-warm followed by an untyped read on the *same* row, i.e. the cross-overload shared-cache case), which test on `ef53a70c` covers that? A test name is enough. Once I have those and have gone through the diff, I will update the findings. <!-- streview-comment:2032 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
