DanielLeens commented on PR #12976: URL: https://github.com/apache/seatunnel/pull/12976#issuecomment-6397814488
Thanks for the contribution. The CI/merge fact in my previous review has changed. The exact-head [fork Build](https://github.com/SEPURI-SAI-KRISHNA/seatunnel/actions/runs/40103455168) is now **completed with failure** for `b8598b8a1c7df9f258f97e96d63d8c2865e9c559`. This is a gate correction, not a second full source review of that unchanged head. The inspected [Java 17 engine job](https://github.com/SEPURI-SAI-KRISHNA/seatunnel/actions/runs/40103455168/job/120900690027) failed in `SplitClusterFaultToleranceIT.testStreamJobCancelResolvesWhenWorkerCrashesBeforeCancelAck`, timing out in `assertEventuallyCanceled` (`:449 -> :557`). It does not point to the locale formatter change. The failing test is unchanged in latest dev. Related cancellation work [#12311](https://github.com/apache/seatunnel/pull/12311) is still open, so I cannot promise that syncing alone fixes this timeout. Please first resolve the already reported EN/ZH incompatible-changes merge conflicts while retaining both sides' entries; then rerun the failed engine job on the resulting new head. If that same cancellation signature repeats, keep its logs with the upstream engine investigation rather than adding formatter changes to chase it. Comparison against dev is `diverged`, ahead 1 / behind 8; merge conflicts: yes. The existing conflict-resolution requirement remains independent of the CI diagnosis. No new source-level blocker from my previous full review is asserted here; a successful required Build and write-capable maintainer approval remain separate gates. Daniel has READ permission, so this comment is not an effective approval. Thanks for keeping the fix focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
