SEPURI-SAI-KRISHNA commented on PR #12976: URL: https://github.com/apache/seatunnel/pull/12976#issuecomment-6437208989
@DanielLeens both of your requests are done, and the result is clean. **The conflicts are resolved.** `#12976` is `MERGEABLE` against current `dev` with no conflict, re-checked after `dev` moved to `c875a87bd` today. Head is `70dcb475d`. **The engine job was rerun on that head and passed.** Only the JDK 17 lane had failed, so that is the one I reran; JDK 11 passed on the original attempt and was left alone. | job | result | duration | | | --- | --- | --- | --- | | `engine-v2-it` (17) | success | 101m24s | rerun | | `engine-v2-it` (11) | success | 84m09s | original attempt | So the `SplitClusterFaultToleranceIT` signature did not repeat. The whole Build is green on `70dcb475d`, with no job in the run anything but success or skipped. Since it did not recur, there is no log to hand to the upstream engine investigation, which is the outcome you described as the alternative. I would call it unreproduced rather than fixed: I have no root cause for the original timeout in `assertEventuallyCanceled`, only the evidence that it does not recur on a rerun of the same head. Your reading that it belongs with the open cancellation work in #12311 rather than with this change still looks right to me, and this change touches no engine file. **One other thing, from @SEZ9's review.** The PR description carried a stale figure: it said `Locale.ROOT` changes 2 of 7 text patterns. The measured numbers are 4 of 10 under `Locale.ROOT` (`MMMM`, `EEEE`, `QQQQ` and `LLLL` all abbreviate) and 0 of 10 under `Locale.ENGLISH`. The description now carries the corrected figures and notes that the earlier number was understated. The docs were already correct; only the description was wrong. So #12976 is green on the reviewed head, conflict free, with the locale-switching test asserting all ten text patterns under four default locales. The remaining gate is the write-access review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
