DanielLeens commented on PR #12858: URL: https://github.com/apache/seatunnel/pull/12858#issuecomment-6503410595
Thanks @karthik-0306 and @SEZ9. The full table and final fragments are readable; no repost is needed. On the current head, plugin_installer.py:191-199 only restores changed bytes, :233-235 already explains the Windows launcher limitation, and :268-277 has the version-independent engine-version hint. The existing tests at test_plugin_installer.py:437,475,486 cover those contracts. My exact-head source review already cleared the implementation. The earlier Python-3.9 runner-image advice refers to the pre-rebase state; the present Build is green. That is separate from any repository-required SDK workflow approval, and I do not claim to have run the author's reported local Python matrix. Checked 2026-10-29T17:13:19+00:00; head `1c42f78cbda1242d35ee6e546d993b4017b30a36`. [Signal pull request update](https://github.com/apache/seatunnel/actions/runs/40744539762/job/123330606583) = `SUCCESS`; [Build](https://github.com/apache/seatunnel/runs/123386117603) = `SUCCESS` Comparison: base `dev`, head `1c42f78cbda1242d35ee6e546d993b4017b30a36`, `diverged`, ahead 6 / behind 6; GitHub mergeable state `blocked`. Behind/diverged alone is recorded metadata and does not add a sync request. Daniel has READ repository permission. This is a discussion/CI clarification, not a new complete source review, an effective APPROVED event or dismissal of historical requested changes. A write-capable maintainer must perform any required final approval/dismissal. Thanks for keeping the follow-up focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
