SEPURI-SAI-KRISHNA commented on PR #13040: URL: https://github.com/apache/seatunnel/pull/13040#issuecomment-6489774132
@nzw921rx thanks, added `DatabendIT.testTimeColumnTypeIsAcceptedByDatabend`. It runs against the real Databend image the IT already starts (`v1.2.71-nightly`): 1. takes the column type `DatabendTypeConverter` gives a SeaTunnel TIME column 2. runs `ALTER TABLE time_column_table ADD COLUMN start_time <that type>` 3. asserts the table now has `id` and `start_time` That image's type grammar has no `TIME`, so on `dev` the converter returns `TIME` and the statement fails to parse. With this PR it returns `STRING` and the column is added. It does not run a job, because none of the existing Databend ITs can emit a schema change event. `databend_schema_evolution.conf` uses a `FakeSource` with a fixed schema, and a job-level test would need a MySQL container and a MySQL CDC job in this module. `DatabendIT.java` compiles, and `spotless:check` on the module is clean. Docker is not available to me, so CI runs it. The PR description is updated to match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
