DanielLeens commented on PR #11512: URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-6655650657
Thanks @goutamadwant for the clear update on every point. **CI:** your re-run worked. Fork run [40159930908](https://github.com/goutamadwant/seatunnel/actions/runs/40159930908) is now `completed / success` on attempt 2, on the exact head `122d0af5fa44`, so the `all-connectors-it-3 (17)` timeout was the shard's time budget and not this change. One loose end: the Apache-side [`Build` check](https://github.com/apache/seatunnel/runs/121069220465) still shows `timed_out`. It came from attempt 1 and did not refresh after the fork re-run. A committer can re-run that `Build` check, and it should pick up the green fork result. If nobody can, the fallback is a new push such as syncing latest `dev`, but that starts the full pipeline again, so please try the re-run first. No source change is needed. **Other points:** all fine with me. - Serializer string/frame bounds as a follow-up PR: agreed, non-blocking. - `addSplitsBack`: the shared-monitor note at `SnapshotSplitAssignerTest.java:358` is enough. - Keeping #12137 stacked as a draft until this lands is the right order. My source conclusion for `122d0af5` is unchanged: no source-side blockers. I will treat CI as passed once the Apache `Build` check shows green on this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
