SEZ9 commented on issue #12809: URL: https://github.com/apache/seatunnel/issues/12809#issuecomment-6621283509
@Nikk8091 thanks for the detailed TableFilter proposal. I don't see any other TableFilter documentation claim or rewrite PR referenced in this thread, so from the tracker's side the TableFilter rewrite is yours. The scope you outlined looks right: - keep the change to `docs/en/transforms/table-filter.md` and `docs/zh/transforms/table-filter.md` in a single documentation-only PR against dev - document every option with type/required/default, how the database/schema/table patterns combine, and INCLUDE vs EXCLUDE behavior - give complete examples that state the expected retained tables, verified against `TableFilterConfig`, `TableFilterTransformFactory`, `TableFilterMultiCatalogTransform` and the existing tests rather than copied from the shared-transform examples - keep EN and ZH in sync describing the same behavior A couple of concrete asks when you open it: 1. Link the PR back here so the claim is traceable in this tracker. 2. In the PR description, list which implementation classes/tests you checked for the multi-table selection and output-table behavior, and distinguish what was validated locally from anything not executed. 3. If verification turns up any code/doc mismatch, open it as a separate issue (as you proposed) and reference it from the PR rather than folding a fix into the docs change. No coordination is needed from my side beyond that—go ahead. <!-- streview-comment:2261 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
