goutamadwant opened a new pull request, #13238:
URL: https://github.com/apache/seatunnel/pull/13238

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code 
changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
     - Make sure that the pull request corresponds to a [GITHUB 
issue](https://github.com/apache/seatunnel/issues).
     - Name the pull request in the form "[Feature] [component] Title of the 
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix 
typo in README.md doc`.
   -->
   
   ### Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull 
request adds checkstyle plugin.-->
   
   I'm contributing this change to Apache SeaTunnel to move multi-table sink 
replica validation to the factory's `OptionRule`.
   
   Closes #13232.
   
   Declare the existing positive replica-count constraint with 
`Conditions.greaterThan(..., 0)` and remove the duplicated constructor guard. 
Preserve the rejected integer in the factory error while retaining the original 
validation exception as its cause.
   
   ### Does this PR introduce _any_ user-facing change?
   
   <!--
   Note that it means *any* user-facing change including all aspects such as 
the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes 
- provide the console output, description and/or an example to show the 
behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to 
the released SeaTunnel versions or within the unreleased branches such as dev.
   If no, write 'No'.
   If you are adding/modifying connector documents, please follow our new 
specifications: https://github.com/apache/seatunnel/issues/4544.
   -->
   
   Yes. This changes invalid-configuration handling on `dev`: nonpositive 
replica counts now fail during factory validation before the composite sink is 
constructed. The outer exception remains `FactoryException`, with an 
`OptionValidationException` cause instead of the previous constructor's 
`IllegalArgumentException`. Diagnostics retain the option name and rejected 
value.
   
   The option remains optional, type `int`, default `1`, with valid range `>= 
1`. Valid create/restore behavior is unchanged. English and Chinese 
documentation describe the validation.
   
   ### How was this patch tested?
   
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   If you are adding E2E test cases, maybe refer to 
https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf,
 here is a good example.
   -->
   
   Added tests for declarative and factory rejection, exact rejected-value 
diagnostics, integer boundaries and a fixed-seed sample, malformed types, 
unrelated construction failures, and valid create/restore with omitted, `1`, 
and `4` replicas. Recovery checks verify per-replica state and executor 
termination after close. Negative controls reproduced the missing rule and 
lost-value diagnostic before the fix.
   
   On JDK 17, 415 API tests passed with no failures, errors, or skips. The 
earlier reactor run also passed 98 dependency tests. Formatting and reactor 
verification passed. The existing Byte Buddy agent was preloaded for API tests 
because dynamic attachment was unavailable locally:
   
   ```bash
   ./mvnw -pl seatunnel-api -am spotless:apply
   ./mvnw -pl seatunnel-api -am \
     '-Dtest=%regex[org/apache/seatunnel/api/.*Test.class]' \
     -Dsurefire.failIfNoSpecifiedTests=false \
     "-Dsurefire.jvm.args=-Dfile.encoding=UTF-8 
-javaagent:${HOME}/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.19/byte-buddy-agent-1.12.19.jar"
 \
     verify
   ```
   
   Live engine integration tests were not run.
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according
     [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
   * [x] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If necessary, please update `incompatible-changes.md` to describe the 
incompatibility caused by this PR.
   * [ ] If you are contributing the connector code, please check that the 
following files are updated:
     1. Update 
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
 and add new connector information in it
     2. Update the pom file of 
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in 
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in 
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/)
     5. Update connector 
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
   
   No new binary dependency or connector was added. No configuration migration 
is required.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to